[lkml]   [2020]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] net: core: devlink.c: Use built-in RCU list checking
Fri, Feb 21, 2020 at 06:35:34PM CET, wrote:
>On Fri, Feb 21, 2020 at 06:20:08PM +0100, Jiri Pirko wrote:
>> Fri, Feb 21, 2020 at 05:51:41PM CET, wrote:
>> >From: Madhuparna Bhowmik <>
>> >
>> >list_for_each_entry_rcu() has built-in RCU and lock checking.
>> >
>> >Pass cond argument to list_for_each_entry_rcu() to silence
>> >false lockdep warning when CONFIG_PROVE_RCU_LIST is enabled
>> >by default.
>> >
>> >Signed-off-by: Madhuparna Bhowmik <>
>> Reviewed-by: Jiri Pirko <>
>> Thanks.
>> However, there is a callpath where not devlink lock neither rcu read is
>> taken:
>> devlink_dpipe_table_register()->devlink_dpipe_table_find()
>Yes I had noticed this, but I was not sure if there is some other lock
>which is being used.
>If yes, then can you please tell me which lock is held in this case,
>and I can add that condition as well to list_for_each_entry_rcu() usage.
>And if no lock or rcu_read_lock is held then may be we should
>use rcu_read_lock/unlock here.
>Let me know what you think about this.

devlink->lock should be held since the beginning of

 \ /
  Last update: 2020-02-21 18:55    [W:0.038 / U:35.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site