lkml.org 
[lkml]   [2020]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 1/3] driver core: Call sync_state() even if supplier has no consumers
On Fri, Feb 21, 2020 at 2:32 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Fri, Feb 21, 2020 at 01:48:49AM -0800, Saravana Kannan wrote:
> > On Fri, Feb 21, 2020 at 1:25 AM Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> > >
> > > On Fri, Feb 21, 2020 at 12:05:08AM -0800, Saravana Kannan wrote:
> > > > The initial patch that added sync_state() support didn't handle the case
> > > > where a supplier has no consumers. This was because when a device is
> > > > successfully bound with a driver, only its suppliers were checked to see
> > > > if they are eligible to get a sync_state(). This is not sufficient for
> > > > devices that have no consumers but still need to do device state clean
> > > > up. So fix this.
> > > >
> > > > Fixes: fc5a251d0fd7ca90 (driver core: Add sync_state driver/bus callback)
> > >
> > > Should be:
> > > Fixes: fc5a251d0fd7 ("driver core: Add sync_state driver/bus callback")
> >
> > Sorry, late night sleepy patches are never good!
> > Btw I thought the sha should be only 12 characters but then saw
> > another instance where you used 16 chars. What's the right one?
>
> I used 16 chars? 12 should be all that is needed.
>
> > > > Signed-off-by: Saravana Kannan <saravanak@google.com>
> > >
> > > So this needs to go to 5.5 also, right?
> >
> > Did you mean 5.4? Yes.
>
> fc5a251d0fd7 is only in 5.5, not 5.4 from what I can see, right?

Ah, right!


-Saravana

\
 
 \ /
  Last update: 2020-02-21 17:02    [W:0.043 / U:0.548 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site