lkml.org 
[lkml]   [2020]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 1/3] regulator: max14577: Add proper dt-compatible strings
    From
    Date
    Hi Mark,

    +CC: Rob Herring, here is the whole thread:

    https://lore.kernel.org/lkml/20200221123813.GB5546@sirena.org.uk/T/#t

    On 21.02.2020 13:38, Mark Brown wrote:
    > On Fri, Feb 21, 2020 at 11:44:03AM +0100, Marek Szyprowski wrote:
    >> On 20.02.2020 17:56, Mark Brown wrote:
    >>
    >>> Why would we want to encode the particular way Linux happens to
    >>> represent regulators on a MFD into the DT binding? It's not clear that
    >>> this is a generic thing (another OS might choose to have a separate
    >>> object for each regulator with no parent for example) and the compatible
    >>> isn't adding any information we didn't have already knowing about the
    >>> parent device.
    >>>
    >> Well, that's how the bindings for max14577/max77836 are defined:
    >>
    >> Documentation/devicetree/bindings/mfd/max14577.txt
    >>
    >> I've only fixed regulator, charger and extcon drivers to match the cells
    >> created by the current mfd driver.
    > We could just remove the compatible strings from the binding
    > documentation, they won't do any harm if we don't use them.

    Frankly I have no strong opinion on this. I've just wanted to fix the
    broken autoloading of the drivers compiled as modules.

    Best regards

    --
    Marek Szyprowski, PhD
    Samsung R&D Institute Poland

    \
     
     \ /
      Last update: 2020-02-21 14:25    [W:3.872 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site