Messages in this thread | | | Subject | Re: [PATCH v4 2/4] gpiolib: use kref in gpio_desc | From | Srinivas Kandagatla <> | Date | Thu, 20 Feb 2020 12:05:48 +0000 |
| |
On 20/02/2020 10:01, Bartosz Golaszewski wrote: > --- a/drivers/gpio/gpiolib.c > +++ b/drivers/gpio/gpiolib.c > @@ -2798,6 +2798,8 @@ static int gpiod_request_commit(struct gpio_desc *desc, const char *label) > goto done; > } > > + kref_init(&desc->ref); > +
Should we not decrement refcount on the error path of this function?
--srini
> if (chip->request) { > /* chip->request may sleep */ > spin_unlock_irqrestore(&gpio_lock, flags); > @@ -2933,6 +2935,13 @@ void gpiod_free(struct gpio_desc *desc) > } > }
| |