Messages in this thread | | | Subject | Re: [PATCH V2] xen: Enable interrupts when calling _cond_resched() | From | Jürgen Groß <> | Date | Wed, 19 Feb 2020 19:42:29 +0100 |
| |
On 19.02.20 18:30, Thomas Gleixner wrote: > xen_maybe_preempt_hcall() is called from the exception entry point > xen_do_hypervisor_callback with interrupts disabled. > > _cond_resched() evades the might_sleep() check in cond_resched() which > would have caught that and schedule_debug() unfortunately lacks a check > for irqs_disabled(). > > Enable interrupts around the call and use cond_resched() to catch future > issues. > > Fixes: fdfd811ddde3 ("x86/xen: allow privcmd hypercalls to be preempted") > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
| |