Messages in this thread | | | Date | Wed, 19 Feb 2020 18:13:09 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH v3 02/22] x86,mce: Delete ist_begin_non_atomic() |
| |
On Wed, Feb 19, 2020 at 03:47:26PM +0100, Peter Zijlstra wrote: > Subject: Re: [PATCH v3 02/22] x86,mce: Delete ist_begin_non_atomic()
x86/mce: ...
> It is an abomination; and in prepration of removing the whole > ist_enter() thing, it needs to go. > > Convert #MC over to using task_work_add() instead; it will run the > same code slightly later, on the return to user path of the same > exception.
That's fine because the error happened in userspace.
...
> @@ -1202,6 +1186,29 @@ static void __mc_scan_banks(struct mce * > *m = *final; > } > > +static void mce_kill_me_now(struct callback_head *ch) > +{ > + force_sig(SIGBUS); > +} > + > +static void mce_kill_me_maybe(struct callback_head *cb)
You don't even need the "mce_" prefixes - those are static functions and in mce-land.
Change looks good otherwise.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |