Messages in this thread | | | Subject | Re: [alsa-devel] [PATCH 4/9] ASoC: tegra: add Tegra210 based I2S driver | From | Sameer Pujar <> | Date | Wed, 19 Feb 2020 21:40:09 +0530 |
| |
On 2/18/2020 6:30 AM, Dmitry Osipenko wrote: > External email: Use caution opening links or attachments > > > 14.02.2020 17:05, Jon Hunter пишет: >> On 29/01/2020 03:41, Dmitry Osipenko wrote: >> >> ... >> >>> The !RPM case isn't supported by Tegra anymore in upstream kernel. I'm >>> trying to help to make yours driver better and gave you reasons to >>> remove the unneeded code, while you're keep saying that "there is no >>> harm to retain it", which is not a reason to clutter up the code. I >>> don't feel that it's worthwhile to continue arguing here. >> On further review, it does look like a reasonable argument to get rid of >> this now completely. Like you see less clutter and the soc-core should >> ensure that the card is shutdown before unloading. OK, so fine with me. > And the RPM core ensures that state is synced on disable, sorry if I > didn't make it clear before. > > +1 for less clutter :)
Done, I am removing explicit RPM suspend in the next revision. Thanks Dmitry and Jon.
| |