Messages in this thread | | | Date | Wed, 19 Feb 2020 09:57:00 +0100 | From | Mike Rapoport <> | Subject | Re: [PATCH v2 RESEND] mm/sparsemem: pfn_to_page is not valid yet on SPARSEMEM |
| |
On Tue, Feb 18, 2020 at 07:25:15PM -0800, Dan Williams wrote: > On Tue, Feb 18, 2020 at 7:05 PM Baoquan He <bhe@redhat.com> wrote: > > > > From: Wei Yang <richardw.yang@linux.intel.com> > > > > When we use SPARSEMEM instead of SPARSEMEM_VMEMMAP, pfn_to_page() > > doesn't work before sparse_init_one_section() is called. This leads to a > > crash when hotplug memory: > > I'd also add: > > "On x86 the impact is limited to x86_32 builds, or x86_64 > configurations that override the default setting for > SPARSEMEM_VMEMMAP".
Do we also want to check how it affects, say, arm64, ia64 and ppc? ;-)
> Other than that: > > Reviewed-by: Dan Williams <dan.j.williams@intel.com> >
-- Sincerely yours, Mike.
| |