Messages in this thread | | | Subject | Re: [PATCH v4 06/20] irqchip/gic-v4.1: Add initial SGI configuration | From | Zenghui Yu <> | Date | Thu, 20 Feb 2020 11:25:41 +0800 |
| |
Hi Marc,
On 2020/2/18 17:46, Marc Zyngier wrote: > Hi Zenghui, > > On 2020-02-18 07:25, Zenghui Yu wrote: >> Hi Marc, > > [...] > >>> static void its_sgi_irq_domain_deactivate(struct irq_domain *domain, >>> struct irq_data *d) >>> { >>> - /* Nothing to do */ >>> + struct its_vpe *vpe = irq_data_get_irq_chip_data(d); >>> + >>> + vpe->sgi_config[d->hwirq].enabled = false; >>> + its_configure_sgi(d, true); >> >> The spec says, when C==1, VSGI clears the pending state of the vSGI, >> leaving the configuration unchanged. So should we first clear the >> pending state and then disable vSGI (let E==0)? > > Right you are again. We need two commands, not just one (the pseudocode is > pretty explicit).
With that change,
Reviewed-by: Zenghui Yu <yuzenghui@huawei.com>
Thanks
| |