Messages in this thread | | | Date | Wed, 19 Feb 2020 21:53:23 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH] backlight: add led-backlight driver |
| |
Hi!
> > This patch adds a led-backlight driver (led_bl), which is similar to > > pwm_bl except the driver uses a LED class driver to adjust the > > brightness in the HW. Multiple LEDs can be used for a single backlight. > > > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> > > Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com> > > Acked-by: Pavel Machek <pavel@ucw.cz> > > Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> > > Acked-by: Lee Jones <lee.jones@linaro.org> > > Acked-by: Tony Lindgren <tony@atomide.com> > > Tested-by: Tony Lindgren <tony@atomide.com> > > Signed-off-by: Pavel Machek <pavel@ucw.cz> > > --- > > drivers/video/backlight/Kconfig | 7 ++ > > drivers/video/backlight/Makefile | 1 + > > drivers/video/backlight/led_bl.c | 260 +++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 268 insertions(+) > > create mode 100644 drivers/video/backlight/led_bl.c
> > Here's the version of the driver I have. AFAICT > > default-brightness-level handling is ok, so does not need to be > > changed. > > > > Lee, it would be easiest for me if you could apply it to your tree and > > push, but given enough time I can push it to Linus, too. > > Oh you're using quoted-printable for patches.. Got it applied now, > and it still works. Below is also the related dts change that > I tested with. > > Feel free to pick the dts change too, naturally that should > not be applied before the driver. > > If you guys instead want me to pick these both into my fixes > branch, just let me know and I'll do the explaining why these > are needed as fixes. Basically we no longer have a way to enable > the LCD backlight for droid4 manually starting with v5.6-rc1 > unlike earlier.
If you are willing to do that, it looks like good solution from my point of view.
Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |