Messages in this thread Patch in this message | | | From | Vincent Guittot <> | Subject | [PATCH] sched/fair: fix statistics for find_idlest_group() | Date | Tue, 18 Feb 2020 15:45:34 +0100 |
| |
sgs->group_weight is not set while gathering statistics in update_sg_wakeup_stats(). This means that a group can be classified as fully busy with 0 running tasks if utilization is high enough.
This path is mainly used for fork and exec.
Fixes: 57abff067a08 ("sched/fair: Rework find_idlest_group()") Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org> --- kernel/sched/fair.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index a7e11b1bb64c..643ed6d8b8ff 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -8354,6 +8354,8 @@ static inline void update_sg_wakeup_stats(struct sched_domain *sd, sgs->group_capacity = group->sgc->capacity; + sgs->group_weight = group->group_weight; + sgs->group_type = group_classify(sd->imbalance_pct, group, sgs); /* -- 2.17.1
| |