Messages in this thread | | | Date | Tue, 18 Feb 2020 18:51:54 -0800 | From | Jaegeuk Kim <> | Subject | Re: [PATCH 3/3] f2fs: avoid unneeded barrier in do_checkpoint() |
| |
On 02/18, Chao Yu wrote: > We don't need to wait all dirty page submitting IO twice, > remove unneeded wait step.
What happens if checkpoint and other meta writs are reordered?
> > Signed-off-by: Chao Yu <yuchao0@huawei.com> > --- > fs/f2fs/checkpoint.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c > index 751815cb4c2b..9c88fb3d255a 100644 > --- a/fs/f2fs/checkpoint.c > +++ b/fs/f2fs/checkpoint.c > @@ -1384,8 +1384,6 @@ static int do_checkpoint(struct f2fs_sb_info *sbi, struct cp_control *cpc) > > /* Flush all the NAT/SIT pages */ > f2fs_sync_meta_pages(sbi, META, LONG_MAX, FS_CP_META_IO); > - /* Wait for all dirty meta pages to be submitted for IO */ > - f2fs_wait_on_all_pages(sbi, F2FS_DIRTY_META); > > /* > * modify checkpoint > -- > 2.18.0.rc1
| |