Messages in this thread Patch in this message | | | From | Matheus Castello <> | Subject | [PATCH v2] clocksource: owl: Improve owl_timer_init fail messages | Date | Tue, 18 Feb 2020 21:48:10 -0300 |
| |
Check the return from clocksource_mmio_init, add messages in case of an error and in case of not having a defined clock property.
Signed-off-by: Matheus Castello <matheus@castello.eng.br> ---
Thanks Manivannan and Andreas for the review. Tested on my Caninos Labrador s500 based board.
Changes since v1: (suggested by maintainers) - Maintains consistency output PTR_ERR(clk) - Returning in case of error on clocksource_mmio_init - Use parentheses between the error code - Remove OF mention
drivers/clocksource/timer-owl.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/drivers/clocksource/timer-owl.c b/drivers/clocksource/timer-owl.c index 900fe736145d..820fbcc05503 100644 --- a/drivers/clocksource/timer-owl.c +++ b/drivers/clocksource/timer-owl.c @@ -135,8 +135,11 @@ static int __init owl_timer_init(struct device_node *node) }
clk = of_clk_get(node, 0); - if (IS_ERR(clk)) - return PTR_ERR(clk); + if (IS_ERR(clk)) { + ret = PTR_ERR(clk); + pr_err("Failed to get clock for clocksource (%d)\n", ret); + return ret; + }
rate = clk_get_rate(clk);
@@ -144,8 +147,12 @@ static int __init owl_timer_init(struct device_node *node) owl_timer_set_enabled(owl_clksrc_base, true);
sched_clock_register(owl_timer_sched_read, 32, rate); - clocksource_mmio_init(owl_clksrc_base + OWL_Tx_VAL, node->name, - rate, 200, 32, clocksource_mmio_readl_up); + ret = clocksource_mmio_init(owl_clksrc_base + OWL_Tx_VAL, node->name, + rate, 200, 32, clocksource_mmio_readl_up); + if (ret) { + pr_err("Failed to register clocksource (%d)\n", ret); + return ret; + }
owl_timer_reset(owl_clkevt_base);
-- 2.25.0
| |