lkml.org 
[lkml]   [2020]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/4] f2fs: clean up lfs/adaptive mount option
On 02/17, Chao Yu wrote:
> On 2020/2/15 2:41, Jaegeuk Kim wrote:
> >> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> >> index 5152e9bf432b..d2d50827772c 100644
> >> --- a/fs/f2fs/f2fs.h
> >> +++ b/fs/f2fs/f2fs.h
> >> @@ -91,8 +91,6 @@ extern const char *f2fs_fault_name[FAULT_MAX];
> >> #define F2FS_MOUNT_FORCE_FG_GC 0x00004000
> >> #define F2FS_MOUNT_DATA_FLUSH 0x00008000
> >> #define F2FS_MOUNT_FAULT_INJECTION 0x00010000
> >> -#define F2FS_MOUNT_ADAPTIVE 0x00020000
> >> -#define F2FS_MOUNT_LFS 0x00040000
> >
> > I don't think we can remove this simply.
> >
> >> #define F2FS_MOUNT_USRQUOTA 0x00080000
> >> #define F2FS_MOUNT_GRPQUOTA 0x00100000
> >> #define F2FS_MOUNT_PRJQUOTA 0x00200000
>
> You mean getting rid of this change or we need to fill F2FS_MOUNT_* hole as below:

nvm. So, we can reuse the removed bits later in other features.

>
> #define F2FS_MOUNT_FAULT_INJECTION 0x00010000
> -#define F2FS_MOUNT_ADAPTIVE 0x00020000
> -#define F2FS_MOUNT_LFS 0x00040000
> +#define F2FS_MOUNT_USRQUOTA 0x00020000
> +#define F2FS_MOUNT_GRPQUOTA 0x00040000
> ...
>
> Thanks,

\
 
 \ /
  Last update: 2020-02-19 00:24    [W:0.072 / U:8.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site