lkml.org 
[lkml]   [2020]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] usb: xhci-pci: Raspberry Pi FW loader for VIA VL805
    From
    Date
    On Mon, 2020-02-17 at 18:47 +0100, Stefan Wahren wrote:
    > > +
    > > + dev_addr = pdev->bus->number << 20 | PCI_SLOT(pdev->devfn) << 15 |
    > > + PCI_FUNC(pdev->devfn) << 12;
    > > +
    > > + ret = rpi_firmware_property(fw, RPI_FIRMWARE_NOTIFY_XHCI_RESET,
    > > + &dev_addr, sizeof(dev_addr));
    > > + if (ret)
    > > + return ret;
    > not sure, but there could be a corner case which should be handled
    > differently. In case the Raspberry Pi 4 has an EEPROM for the VL805
    > firmware but the firmware is too old to handle
    > RPI_FIRMWARE_NOTIFY_XHCI_RESET, we should return with 0. I don't know
    > there is a change to detect this reliable. I just want to mention this.

    Ouch, good point, that can be problematic. I'll test that scenario tomorrow.

    > > diff --git a/include/soc/bcm2835/raspberrypi-firmware.h
    > > b/include/soc/bcm2835/raspberrypi-firmware.h
    > > index 7800e12ee042..cc9cdbc66403 100644
    > > --- a/include/soc/bcm2835/raspberrypi-firmware.h
    > > +++ b/include/soc/bcm2835/raspberrypi-firmware.h
    > > @@ -90,7 +90,7 @@ enum rpi_firmware_property_tag {
    > > RPI_FIRMWARE_SET_PERIPH_REG = 0x00038045,
    > > RPI_FIRMWARE_GET_POE_HAT_VAL = 0x00030049,
    > > RPI_FIRMWARE_SET_POE_HAT_VAL = 0x00030050,
    > > -
    > > + RPI_FIRMWARE_NOTIFY_XHCI_RESET = 0x00030058,
    >
    > In past we updated the firmware mailbox property interface in a bunch as
    > a separate patch. So we can avoid those gaps.

    Ok, I'll change that.

    Regards,
    Nicolas

    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2020-02-17 20:40    [W:3.316 / U:0.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site