Messages in this thread | | | Date | Mon, 17 Feb 2020 16:29:12 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH devicetree 3/4] arm64: dts: fsl: ls1028a: add node for Felix switch |
| |
Hi Vladimir
> + /* Internal port with DSA tagging */ > + mscc_felix_port4: port@4 { > + reg = <4>; > + phy-mode = "gmii";
Is it really using gmii? Often in SoC connections use something else, and phy-mode = "internal" is more appropriate.
> + ethernet = <&enetc_port2>; > + > + fixed-link { > + speed = <2500>; > + full-duplex; > + };
gmii and 2500 also don't really go together.
Andrew
| |