lkml.org 
[lkml]   [2020]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH devicetree 3/4] arm64: dts: fsl: ls1028a: add node for Felix switch
Hi Vladimir

> + /* Internal port with DSA tagging */
> + mscc_felix_port4: port@4 {
> + reg = <4>;
> + phy-mode = "gmii";

Is it really using gmii? Often in SoC connections use something else,
and phy-mode = "internal" is more appropriate.

> + ethernet = <&enetc_port2>;
> +
> + fixed-link {
> + speed = <2500>;
> + full-duplex;
> + };

gmii and 2500 also don't really go together.

Andrew

\
 
 \ /
  Last update: 2020-02-17 16:29    [W:0.067 / U:0.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site