Messages in this thread | | | Date | Mon, 17 Feb 2020 15:02:08 +0000 | From | Mark Brown <> | Subject | Re: [RFC PATCH 05/34] ASoC: sun8i-codec: Remove incorrect SND_SOC_DAIFMT_DSP_B |
| |
On Mon, Feb 17, 2020 at 12:42:21AM -0600, Samuel Holland wrote: > DSP_A and DSP_B are not interchangeable. The timing used by the codec in > DSP mode is consistent with DSP_A. This is verified with an EG25-G modem > connected to AIF2, as well as by comparing with the BSP driver. > > Remove the DSP_B option, as it is not supported by the hardware. > > Cc: stable@kernel.org > Fixes: 36c684936fae ("ASoC: Add sun8i digital audio codec")
This can only break things for existing systems using stable, if they haven't noticed a problem with DSP B they'll certainly notice failing to set up the DAI at all without it. [unhandled content-type:application/pgp-signature] | |