lkml.org 
[lkml]   [2020]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 1/4] mtd: rawnand: Add support manufacturer specific lock/unlock operatoin
From
Date

Hi Miquel,


> > /* Set default functions */
> > static void nand_set_defaults(struct nand_chip *chip)
> > {
> > @@ -5782,8 +5810,8 @@ static int nand_scan_tail(struct nand_chip
*chip)
> > mtd->_read_oob = nand_read_oob;
> > mtd->_write_oob = nand_write_oob;
> > mtd->_sync = nand_sync;
> > - mtd->_lock = NULL;
> > - mtd->_unlock = NULL;
> > + mtd->_lock = nand_lock;
> > + mtd->_unlock = nand_unlock;
> > mtd->_suspend = nand_suspend;
> > mtd->_resume = nand_resume;
> > mtd->_reboot = nand_shutdown;
> > diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h
> > index 4ab9bcc..2430ecd 100644
> > --- a/include/linux/mtd/rawnand.h
> > +++ b/include/linux/mtd/rawnand.h
> > @@ -1136,6 +1136,9 @@ struct nand_chip {
> > const struct nand_manufacturer *desc;
> > void *priv;
> > } manufacturer;
> > +
> > + int (*_lock)(struct nand_chip *chip, loff_t ofs, uint64_t len);
> > + int (*_unlock)(struct nand_chip *chip, loff_t ofs, uint64_t len);
>
> Kernel documentation is missing here.
>
> Also please fix kbuildtest robot warnings.

okay, will fix both !

>
> With all this done, please add my:
> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
>
> Thanks,
> Miquèl

thanks for your time & comments.
Mason



CONFIDENTIALITY NOTE:

This e-mail and any attachments may contain confidential information
and/or personal data, which is protected by applicable laws. Please be
reminded that duplication, disclosure, distribution, or use of this e-mail
(and/or its attachments) or any part thereof is prohibited. If you receive
this e-mail in error, please notify us immediately and delete this mail as
well as its attachment(s) from your system. In addition, please be
informed that collection, processing, and/or use of personal data is
prohibited unless expressly permitted by personal data protection laws.
Thank you for your attention and cooperation.

Macronix International Co., Ltd.

=====================================================================



============================================================================

CONFIDENTIALITY NOTE:

This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation.

Macronix International Co., Ltd.

=====================================================================

\
 
 \ /
  Last update: 2020-02-17 09:05    [W:0.119 / U:3.608 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site