Messages in this thread Patch in this message | | | From | linmiaohe <> | Subject | [PATCH] KVM: VMX: replace "fall through" with "return true" to indicate different case | Date | Tue, 18 Feb 2020 11:39:28 +0800 |
| |
From: Miaohe Lin <linmiaohe@huawei.com>
The second "/* fall through */" in rmode_exception() makes code harder to read. Replace it with "return true" to indicate they are different cases and also this improves the readability.
Suggested-by: Vitaly Kuznetsov <vkuznets@redhat.com> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> --- arch/x86/kvm/vmx/vmx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c index a13368b2719c..c5bcbbada2db 100644 --- a/arch/x86/kvm/vmx/vmx.c +++ b/arch/x86/kvm/vmx/vmx.c @@ -4495,7 +4495,7 @@ static bool rmode_exception(struct kvm_vcpu *vcpu, int vec) if (vcpu->guest_debug & (KVM_GUESTDBG_SINGLESTEP | KVM_GUESTDBG_USE_HW_BP)) return false; - /* fall through */ + return true; case DE_VECTOR: case OF_VECTOR: case BR_VECTOR: -- 2.19.1
| |