Messages in this thread | | | Subject | Re: [RFC PATCH 08/34] ASoC: sun8i-codec: Fix direction of AIF1 outputs | From | Samuel Holland <> | Date | Mon, 17 Feb 2020 19:44:49 -0600 |
| |
On 2/17/20 9:09 AM, Mark Brown wrote: > On Mon, Feb 17, 2020 at 12:42:24AM -0600, Samuel Holland wrote: >> The naming convention for AIFs in this codec is to call the "DAC" the >> path from the AIF into the codec, and the ADC the path from the codec >> back to the AIF, regardless of if there is any analog path involved. > > This renames widgets but does not update any DAPM routes from those > widgets which will break things if this patch is applied.
This commit doesn't change the widget name, only the widget type. My commit message did not make that clear.
>> Cc: stable@kernel.org > > Why is this suitable for stable? It's a random textual cleanup.
This was one of the first patches I wrote. Now that I understand DAPM better, I realize that it has no functional impact, and this shouldn't go to stable. (snd_soc_dapm_aif_in and snd_soc_dapm_aif_out are handled exactly the same, so fixing the widget type is, as you say, just a textual cleanup.)
| |