Messages in this thread | | | Date | Mon, 17 Feb 2020 23:34:15 +0000 | From | Qais Yousef <> | Subject | Re: [PATCH 1/3] sched/rt: cpupri_find: implement fallback mechanism for !fit case |
| |
On 02/17/20 17:07, Valentin Schneider wrote: > Just a drive-by comment; could you split that code move into its own patch? > It'd make the history a bit easier to read IMO.
Hmm I don't see how it would help the history.
In large series with big churn splitting helps to facilitate review, but I don't think reviewing this patch is hard because of creating the new function.
And git-blame will have this patch all over the new function, so people who care to know the reason of the split will land at the right place directly without any extra level of indirection.
Thanks
-- Qais Yousef
| |