Messages in this thread | | | From | Toke Høiland-Jørgensen <> | Subject | Re: [PATCH net-next] net: page_pool: API cleanup and comments | Date | Sun, 16 Feb 2020 11:33:55 +0100 |
| |
Ilias Apalodimas <ilias.apalodimas@linaro.org> writes:
> Functions starting with __ usually indicate those which are exported, > but should not be called directly. Update some of those declared in the > API and make it more readable. > > page_pool_unmap_page() and page_pool_release_page() were doing > exactly the same thing. Keep the page_pool_release_page() variant > and export it in order to show up on perf logs. > Finally rename __page_pool_put_page() to page_pool_put_page() since we > can now directly call it from drivers and rename the existing > page_pool_put_page() to page_pool_put_full_page() since they do the same > thing but the latter is trying to sync the full DMA area. > > Also update netsec, mvneta and stmmac drivers which use those functions. > > Suggested-by: Jonathan Lemon <jonathan.lemon@gmail.com> > Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Thanks for the house cleaning :)
Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
| |