Messages in this thread | | | Date | Fri, 14 Feb 2020 21:35:17 -0800 | From | Bjorn Andersson <> | Subject | Re: [PATCH 2/2] pinctrl: Use new GPIO_LINE_DIRECTION |
| |
On Tue 12 Nov 06:18 PST 2019, Matti Vaittinen wrote: > diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c > index 763da0be10d6..8844ca1261d5 100644 > --- a/drivers/pinctrl/qcom/pinctrl-msm.c > +++ b/drivers/pinctrl/qcom/pinctrl-msm.c > @@ -485,8 +485,8 @@ static int msm_gpio_get_direction(struct gpio_chip *chip, unsigned int offset) > > val = msm_readl_ctl(pctrl, g); > > - /* 0 = output, 1 = input */ > - return val & BIT(g->oe_bit) ? 0 : 1; > + return val & BIT(g->oe_bit) ? GPIO_LINE_DIRECTION_OUT : > + GPIO_LINE_DIRECTION_IN;
For pinctrl-msm: Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> }
Regards, Bjorn
| |