lkml.org 
[lkml]   [2020]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.4 389/459] bcache: cached_dev_free needs to put the sb page
    Date
    From: Liang Chen <liangchen.linux@gmail.com>

    [ Upstream commit e8547d42095e58bee658f00fef8e33d2a185c927 ]

    Same as cache device, the buffer page needs to be put while
    freeing cached_dev. Otherwise a page would be leaked every
    time a cached_dev is stopped.

    Signed-off-by: Liang Chen <liangchen.linux@gmail.com>
    Signed-off-by: Christoph Hellwig <hch@lst.de>
    Signed-off-by: Coly Li <colyli@suse.de>
    Signed-off-by: Jens Axboe <axboe@kernel.dk>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/md/bcache/super.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
    index 64999c7a8033f..b86cf72033401 100644
    --- a/drivers/md/bcache/super.c
    +++ b/drivers/md/bcache/super.c
    @@ -1274,6 +1274,9 @@ static void cached_dev_free(struct closure *cl)

    mutex_unlock(&bch_register_lock);

    + if (dc->sb_bio.bi_inline_vecs[0].bv_page)
    + put_page(bio_first_page_all(&dc->sb_bio));
    +
    if (!IS_ERR_OR_NULL(dc->bdev))
    blkdev_put(dc->bdev, FMODE_READ|FMODE_WRITE|FMODE_EXCL);

    --
    2.20.1
    \
     
     \ /
      Last update: 2020-02-14 17:11    [W:4.017 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site