lkml.org 
[lkml]   [2020]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.5 044/542] media: sun4i-csi: Fix data sampling polarity handling
    Date
    From: Chen-Yu Tsai <wens@csie.org>

    [ Upstream commit cf9e6d5dbdd56ef2aa72f28c806711c4293c8848 ]

    The CLK_POL field specifies whether data is sampled on the falling or
    rising edge of PCLK, not whether the data lines are active high or low.
    Evidence of this can be found in the timing diagram labeled "horizontal
    size setting and pixel clock timing".

    Fix the setting by checking the correct flag, V4L2_MBUS_PCLK_SAMPLE_RISING.
    While at it, reorder the three polarity flag checks so HSYNC and VSYNC
    are grouped together.

    Fixes: 577bbf23b758 ("media: sunxi: Add A10 CSI driver")
    Signed-off-by: Chen-Yu Tsai <wens@csie.org>
    Acked-by: Maxime Ripard <mripard@kernel.org>
    Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/platform/sunxi/sun4i-csi/sun4i_dma.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/media/platform/sunxi/sun4i-csi/sun4i_dma.c b/drivers/media/platform/sunxi/sun4i-csi/sun4i_dma.c
    index d6979e11a67b2..8b567d0f019bf 100644
    --- a/drivers/media/platform/sunxi/sun4i-csi/sun4i_dma.c
    +++ b/drivers/media/platform/sunxi/sun4i-csi/sun4i_dma.c
    @@ -279,8 +279,8 @@ static int sun4i_csi_start_streaming(struct vb2_queue *vq, unsigned int count)
    csi->regs + CSI_WIN_CTRL_H_REG);

    hsync_pol = !!(bus->flags & V4L2_MBUS_HSYNC_ACTIVE_HIGH);
    - pclk_pol = !!(bus->flags & V4L2_MBUS_DATA_ACTIVE_HIGH);
    vsync_pol = !!(bus->flags & V4L2_MBUS_VSYNC_ACTIVE_HIGH);
    + pclk_pol = !!(bus->flags & V4L2_MBUS_PCLK_SAMPLE_RISING);
    writel(CSI_CFG_INPUT_FMT(csi_fmt->input) |
    CSI_CFG_OUTPUT_FMT(csi_fmt->output) |
    CSI_CFG_VSYNC_POL(vsync_pol) |
    --
    2.20.1
    \
     
     \ /
      Last update: 2020-02-14 16:50    [W:3.016 / U:4.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site