lkml.org 
[lkml]   [2020]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 28/30] tipc: Add missing annotation for tipc_node_write_unlock()
    Date
    Sparse reports a warning at tipc_node_write_unlock()

    warning: context imbalance in tipc_node_write_unlock
    - unexpected unlock

    The root cause is the missing annotation at tipc_node_write_unlock()
    Add the missing __releases(&n->lock) annotation

    Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
    ---
    net/tipc/node.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/net/tipc/node.c b/net/tipc/node.c
    index cc656b2205db..c3b810427d24 100644
    --- a/net/tipc/node.c
    +++ b/net/tipc/node.c
    @@ -372,7 +372,7 @@ static void tipc_node_write_unlock_fast(struct tipc_node *n)
    write_unlock_bh(&n->lock);
    }

    -static void tipc_node_write_unlock(struct tipc_node *n)
    +static void tipc_node_write_unlock(struct tipc_node *n) __releases(&n->lock)
    {
    struct net *net = n->net;
    u32 addr = 0;
    --
    2.24.1
    \
     
     \ /
      Last update: 2020-02-14 21:50    [W:3.108 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site