lkml.org 
[lkml]   [2020]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 17/30] drm/vkms: Add missing annotation for vkms_crtc_atomic_flush()
    Date
    Sparse reports a warning at vkms_crtc_atomic_flush()

    warning: context imbalance in vkms_crtc_atomic_flush()
    - unexpected unlock

    The root cause is the missing annotation at vkms_crtc_atomic_flush()
    Add the missing __releases(&vkms_output->lock) annotation

    Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
    ---
    drivers/gpu/drm/vkms/vkms_crtc.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c b/drivers/gpu/drm/vkms/vkms_crtc.c
    index 7513be6444ae..bc0ac2641220 100644
    --- a/drivers/gpu/drm/vkms/vkms_crtc.c
    +++ b/drivers/gpu/drm/vkms/vkms_crtc.c
    @@ -231,6 +231,7 @@ static void vkms_crtc_atomic_begin(struct drm_crtc *crtc,

    static void vkms_crtc_atomic_flush(struct drm_crtc *crtc,
    struct drm_crtc_state *old_crtc_state)
    + __releases(&vkms_output->lock)
    {
    struct vkms_output *vkms_output = drm_crtc_to_vkms_output(crtc);

    --
    2.24.1
    \
     
     \ /
      Last update: 2020-02-14 21:49    [W:4.270 / U:2.312 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site