lkml.org 
[lkml]   [2020]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/3] dt-binding: gce: remove atomic_exec in mboxes property
From
Date


On 14/02/2020 05:33, Bibby Hsieh wrote:
> There is not any client driver using this feature now,
> so remove it from binding.
>
> Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
> ---
> Documentation/devicetree/bindings/mailbox/mtk-gce.txt | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> index 7b13787ab13d..0b5b2a6bcc48 100644
> --- a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> +++ b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> @@ -14,13 +14,11 @@ Required properties:
> - interrupts: The interrupt signal from the GCE block
> - clock: Clocks according to the common clock binding
> - clock-names: Must be "gce" to stand for GCE clock
> -- #mbox-cells: Should be 3.
> - <&phandle channel priority atomic_exec>
> +- #mbox-cells: Should be 2.
> + <&phandle channel priority>

Normally we will need to support backwards compatibility for three cells. As we
don't have a consumer of the mailbox interface for now, I think we are fine
without providing atomic_exec in the driver and the DT.

Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>

Ah, by the way. Please beware that devicetree maintainer prefer to have the
binding changes in the first patch of a series, as it makes their live easier.

Regards,
Matthias

> phandle: Label name of a gce node.
> channel: Channel of mailbox. Be equal to the thread id of GCE.
> priority: Priority of GCE thread.
> - atomic_exec: GCE processing continuous packets of commands in atomic
> - way.
>
> Required properties for a client device:
> - mboxes: Client use mailbox to communicate with GCE, it should have this
> @@ -54,8 +52,8 @@ Example for a client device:
>
> mmsys: clock-controller@14000000 {
> compatible = "mediatek,mt8173-mmsys";
> - mboxes = <&gce 0 CMDQ_THR_PRIO_LOWEST 1>,
> - <&gce 1 CMDQ_THR_PRIO_LOWEST 1>;
> + mboxes = <&gce 0 CMDQ_THR_PRIO_LOWEST>,
> + <&gce 1 CMDQ_THR_PRIO_LOWEST>;
> mutex-event-eof = <CMDQ_EVENT_MUTEX0_STREAM_EOF
> CMDQ_EVENT_MUTEX1_STREAM_EOF>;
> mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0x3000 0x1000>,
>

\
 
 \ /
  Last update: 2020-02-14 11:30    [W:0.053 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site