Messages in this thread | | | Date | Fri, 14 Feb 2020 20:05:37 +0000 | From | Mark Brown <> | Subject | Re: [PATCH] ASoC: ti: Allocate dais dynamically for TDM and audio graph card |
| |
On Fri, Feb 14, 2020 at 09:05:59AM -0800, Tony Lindgren wrote: > * Mark Brown <broonie@kernel.org> [200214 12:50]:
> > We really shouldn't need dummy DAIs at all I think, if we do it feels > > like there's a problem. It's quite possible that there is actually a > > problem here though...
> It's dummy in the droid4 voice call case as mcbsp is not the clock-master > and there's nothing to configure for mcbsp.
If the McBSP is doing anything at all it should still be properly represented with the actual device rather than a dummy otherwise we'll most likely get confused at some point. If it's not doing anything then we shouldn't even need the dummy. But perhaps I'm confused about this particular system, I remember some of the OMAP designs were a bit fun.
> But I guess in some cases mcbsp could be the clock-master and then the > secondary DAI would have ops.
It'd be a bit of an unusual clock design for a phone but yeah. [unhandled content-type:application/pgp-signature] | |