lkml.org 
[lkml]   [2020]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.5 056/542] kernel/module: Fix memleak in module_add_modinfo_attrs()
    Date
    From: YueHaibing <yuehaibing@huawei.com>

    [ Upstream commit f6d061d617124abbd55396a3bc37b9bf7d33233c ]

    In module_add_modinfo_attrs() if sysfs_create_file() fails
    on the first iteration of the loop (so i = 0), we forget to
    free the modinfo_attrs.

    Fixes: bc6f2a757d52 ("kernel/module: Fix mem leak in module_add_modinfo_attrs")
    Reviewed-by: Miroslav Benes <mbenes@suse.cz>
    Signed-off-by: YueHaibing <yuehaibing@huawei.com>
    Signed-off-by: Jessica Yu <jeyu@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    kernel/module.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/kernel/module.c b/kernel/module.c
    index b56f3224b161b..8785e31c2dd0f 100644
    --- a/kernel/module.c
    +++ b/kernel/module.c
    @@ -1781,6 +1781,8 @@ static int module_add_modinfo_attrs(struct module *mod)
    error_out:
    if (i > 0)
    module_remove_modinfo_attrs(mod, --i);
    + else
    + kfree(mod->modinfo_attrs);
    return error;
    }

    --
    2.20.1
    \
     
     \ /
      Last update: 2020-02-14 19:20    [W:2.375 / U:1.424 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site