lkml.org 
[lkml]   [2020]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.5 176/542] regulator: rk808: Lower log level on optional GPIOs being not available
    Date
    From: Miquel Raynal <miquel.raynal@bootlin.com>

    [ Upstream commit b8a039d37792067c1a380dc710361905724b9b2f ]

    RK808 can leverage a couple of GPIOs to tweak the ramp rate during DVS
    (Dynamic Voltage Scaling). These GPIOs are entirely optional but a
    dev_warn() appeared when cleaning this driver to use a more up-to-date
    gpiod API. At least reduce the log level to 'info' as it is totally
    fine to not populate these GPIO on a hardware design.

    This change is trivial but it is worth not polluting the logs during
    bringup phase by having real warnings and errors sorted out
    correctly.

    Fixes: a13eaf02e2d6 ("regulator: rk808: make better use of the gpiod API")
    Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
    Link: https://lore.kernel.org/r/20191203164709.11127-1-miquel.raynal@bootlin.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/regulator/rk808-regulator.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/regulator/rk808-regulator.c b/drivers/regulator/rk808-regulator.c
    index 5b40032264846..31f79fda3238b 100644
    --- a/drivers/regulator/rk808-regulator.c
    +++ b/drivers/regulator/rk808-regulator.c
    @@ -1282,7 +1282,7 @@ static int rk808_regulator_dt_parse_pdata(struct device *dev,
    }

    if (!pdata->dvs_gpio[i]) {
    - dev_warn(dev, "there is no dvs%d gpio\n", i);
    + dev_info(dev, "there is no dvs%d gpio\n", i);
    continue;
    }

    --
    2.20.1
    \
     
     \ /
      Last update: 2020-02-14 19:13    [W:2.721 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site