lkml.org 
[lkml]   [2020]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.5 215/542] isdn: don't mark kcapi_proc_exit as __exit
    Date
    From: Arnd Bergmann <arnd@arndb.de>

    [ Upstream commit b33bdf8020c94438269becc6dace9ed49257c4ba ]

    As everybody pointed out by now, my patch to clean up CAPI introduced
    a link time warning, as the two parts of the capi driver are now in
    one module and the exit function may need to be called in the error
    path of the init function:

    >> WARNING: drivers/isdn/capi/kernelcapi.o(.text+0xea4): Section mismatch in reference from the function kcapi_exit() to the function .exit.text:kcapi_proc_exit()
    The function kcapi_exit() references a function in an exit section.
    Often the function kcapi_proc_exit() has valid usage outside the exit section
    and the fix is to remove the __exit annotation of kcapi_proc_exit.

    Remove the incorrect __exit annotation.

    Reported-by: kbuild test robot <lkp@intel.com>
    Reported-by: kernelci.org bot <bot@kernelci.org>
    Reported-by: Olof's autobuilder <build@lixom.net>
    Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Link: https://lore.kernel.org/r/20191216194909.1983639-1-arnd@arndb.de
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/isdn/capi/kcapi_proc.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/isdn/capi/kcapi_proc.c b/drivers/isdn/capi/kcapi_proc.c
    index c94bd12c0f7c6..28cd051f1dfd9 100644
    --- a/drivers/isdn/capi/kcapi_proc.c
    +++ b/drivers/isdn/capi/kcapi_proc.c
    @@ -239,7 +239,7 @@ kcapi_proc_init(void)
    proc_create_seq("capi/driver", 0, NULL, &seq_capi_driver_ops);
    }

    -void __exit
    +void
    kcapi_proc_exit(void)
    {
    remove_proc_entry("capi/driver", NULL);
    --
    2.20.1
    \
     
     \ /
      Last update: 2020-02-14 19:11    [W:3.141 / U:0.648 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site