lkml.org 
[lkml]   [2020]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/5] x86/mce: Change default mce logger to check mce->handled
On Thu, Feb 13, 2020 at 02:27:50PM -0800, Luck, Tony wrote:
> That's pretty hard with a chain. I think folks will have a conniptions

LOL. And they do already for other things so let's spare them :-)

> if we invent an error return from a notifier chain function that means
> "Go back and start over". Though if we did it would make the "handled"
> field useful for functions that didn't want to redo ... they'd just
> check if "their" bit in handled was already set.
>
> Still, seems like a terrible idea.

Yap.

> If some driver really wants multiple bites at an error on the
> chain it could register more than one handler with different
> priorities. In which case we should have "enum" names for the
> highest and lowest priorities so such a driver can go "first"
> or "last" (though such a thing would be dependent on whether
> some other driver was attempting to add a "first" or "last"
> entry on the chain).

Yap, makes sense. I'm fine with us even having a possible way to do
this, *if* someone decides she wants it.

Ok, thanks!

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette

\
 
 \ /
  Last update: 2020-02-14 10:06    [W:0.048 / U:4.844 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site