lkml.org 
[lkml]   [2020]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.4 210/459] scsi: aic7xxx: Adjust indentation in ahc_find_syncrate
    Date
    From: Nathan Chancellor <natechancellor@gmail.com>

    [ Upstream commit 4dbc96ad65c45cdd4e895ed7ae4c151b780790c5 ]

    Clang warns:

    ../drivers/scsi/aic7xxx/aic7xxx_core.c:2317:5: warning: misleading
    indentation; statement is not part of the previous 'if'
    [-Wmisleading-indentation]
    if ((syncrate->sxfr_u2 & ST_SXFR) != 0)
    ^
    ../drivers/scsi/aic7xxx/aic7xxx_core.c:2310:4: note: previous statement
    is here
    if (syncrate == &ahc_syncrates[maxsync])
    ^
    1 warning generated.

    This warning occurs because there is a space amongst the tabs on this
    line. Remove it so that the indentation is consistent with the Linux kernel
    coding style and clang no longer warns.

    This has been a problem since the beginning of git history hence no fixes
    tag.

    Link: https://github.com/ClangBuiltLinux/linux/issues/817
    Link: https://lore.kernel.org/r/20191218014220.52746-1-natechancellor@gmail.com
    Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/aic7xxx/aic7xxx_core.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/scsi/aic7xxx/aic7xxx_core.c b/drivers/scsi/aic7xxx/aic7xxx_core.c
    index a9d40d3b90efc..4190a025381a5 100644
    --- a/drivers/scsi/aic7xxx/aic7xxx_core.c
    +++ b/drivers/scsi/aic7xxx/aic7xxx_core.c
    @@ -2314,7 +2314,7 @@ ahc_find_syncrate(struct ahc_softc *ahc, u_int *period,
    * At some speeds, we only support
    * ST transfers.
    */
    - if ((syncrate->sxfr_u2 & ST_SXFR) != 0)
    + if ((syncrate->sxfr_u2 & ST_SXFR) != 0)
    *ppr_options &= ~MSG_EXT_PPR_DT_REQ;
    break;
    }
    --
    2.20.1
    \
     
     \ /
      Last update: 2020-02-14 18:31    [W:5.051 / U:0.812 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site