lkml.org 
[lkml]   [2020]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.4 245/459] ALSA: hda/realtek - Apply mic mute LED quirk for Dell E7xx laptops, too
    Date
    From: Takashi Iwai <tiwai@suse.de>

    [ Upstream commit 5fab5829674c279839a7408ab30c71c6dfe726b9 ]

    Dell E7xx laptops have also mic mute LED that is driven by the
    dell-laptop platform driver. Bind it with the capture control as
    already done for other models.

    A caveat is that the fixup hook for the mic mute LED has to be applied
    at last, otherwise it results in the invalid override of the callback.

    BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=205529
    Link: https://lore.kernel.org/r/20200105081119.21396-1-tiwai@suse.de
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/pci/hda/patch_realtek.c | 10 +++++++++-
    1 file changed, 9 insertions(+), 1 deletion(-)

    diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
    index 68832f52c1ad2..e8d5f6befa1f3 100644
    --- a/sound/pci/hda/patch_realtek.c
    +++ b/sound/pci/hda/patch_realtek.c
    @@ -5848,6 +5848,7 @@ enum {
    ALC288_FIXUP_DELL1_MIC_NO_PRESENCE,
    ALC288_FIXUP_DELL_XPS_13,
    ALC288_FIXUP_DISABLE_AAMIX,
    + ALC292_FIXUP_DELL_E7X_AAMIX,
    ALC292_FIXUP_DELL_E7X,
    ALC292_FIXUP_DISABLE_AAMIX,
    ALC293_FIXUP_DISABLE_AAMIX_MULTIJACK,
    @@ -6543,12 +6544,19 @@ static const struct hda_fixup alc269_fixups[] = {
    .chained = true,
    .chain_id = ALC293_FIXUP_DELL1_MIC_NO_PRESENCE
    },
    - [ALC292_FIXUP_DELL_E7X] = {
    + [ALC292_FIXUP_DELL_E7X_AAMIX] = {
    .type = HDA_FIXUP_FUNC,
    .v.func = alc_fixup_dell_xps13,
    .chained = true,
    .chain_id = ALC292_FIXUP_DISABLE_AAMIX
    },
    + [ALC292_FIXUP_DELL_E7X] = {
    + .type = HDA_FIXUP_FUNC,
    + .v.func = snd_hda_gen_fixup_micmute_led,
    + /* micmute fixup must be applied at last */
    + .chained_before = true,
    + .chain_id = ALC292_FIXUP_DELL_E7X_AAMIX,
    + },
    [ALC298_FIXUP_ALIENWARE_MIC_NO_PRESENCE] = {
    .type = HDA_FIXUP_PINS,
    .v.pins = (const struct hda_pintbl[]) {
    --
    2.20.1
    \
     
     \ /
      Last update: 2020-02-14 18:31    [W:4.086 / U:0.280 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site