Messages in this thread | | | Subject | Re: [v2 PATCH] mm: shmem: allow split THP when truncating THP partially | From | Yang Shi <> | Date | Fri, 14 Feb 2020 09:17:26 -0800 |
| |
On 2/14/20 7:40 AM, Kirill A. Shutemov wrote: > On Thu, Feb 13, 2020 at 04:38:01PM -0800, Yang Shi wrote: >> Hi Kirill, >> >> >> Would you please help review this patch? I don't know why Hugh didn't >> response though I pinged him twice. > I have not noticed anything wrong with the patch. > > But the function gets ugly beyond the reason. Any chance you could > restructure it to get somewhat maintainable? (It's not easy, I know).
Yes, those goto looks not neat. I'm going to give it a try. Any suggestion is absolutely welcome.
>
| |