lkml.org 
[lkml]   [2020]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH V4] mfd: da9062: add support for interrupt polarity defined in device tree
Hi Shreyas,

thanks for your patch!

On Thu, Feb 13, 2020 at 6:40 AM Shreyas Joshi <shreyas.joshi@biamp.com> wrote:

> + switch (*trigger) {
> + case IRQ_TYPE_LEVEL_HIGH:
> + irq_type = 1;
> + break;
> + case IRQ_TYPE_LEVEL_LOW:
> + irq_type = 0;
> + break;

Please create #defines for the level indicator, like

#define DA9062_IRQ_HIGH 1
#define DA9062_IRQ_LOW 0

and use that.

With that change:
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

\
 
 \ /
  Last update: 2020-02-14 08:59    [W:0.037 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site