lkml.org 
[lkml]   [2020]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.5 029/120] NFS: Revalidate the file size on a fatal write error
    Date
    From: Trond Myklebust <trondmy@gmail.com>

    commit 0df68ced55443243951d02cc497be31fadf28173 upstream.

    If we suffer a fatal error upon writing a file, which causes us to
    need to revalidate the entire mapping, then we should also revalidate
    the file size.

    Fixes: d2ceb7e57086 ("NFS: Don't use page_file_mapping after removing the page")
    Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
    Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/nfs/write.c | 8 ++++++++
    1 file changed, 8 insertions(+)

    --- a/fs/nfs/write.c
    +++ b/fs/nfs/write.c
    @@ -243,7 +243,15 @@ out:
    /* A writeback failed: mark the page as bad, and invalidate the page cache */
    static void nfs_set_pageerror(struct address_space *mapping)
    {
    + struct inode *inode = mapping->host;
    +
    nfs_zap_mapping(mapping->host, mapping);
    + /* Force file size revalidation */
    + spin_lock(&inode->i_lock);
    + NFS_I(inode)->cache_validity |= NFS_INO_REVAL_FORCED |
    + NFS_INO_REVAL_PAGECACHE |
    + NFS_INO_INVALID_SIZE;
    + spin_unlock(&inode->i_lock);
    }

    static void nfs_mapping_set_error(struct page *page, int error)

    \
     
     \ /
      Last update: 2020-02-13 16:33    [W:4.116 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site