lkml.org 
[lkml]   [2020]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC 2/4] sched/numa: replace runnable_load_avg by load_avg
On Thu, Feb 13, 2020 at 10:00:26AM -0500, Phil Auld wrote:
> On Thu, Feb 13, 2020 at 01:46:55PM +0000 Mel Gorman wrote:
> > On Thu, Feb 13, 2020 at 09:16:58PM +0800, Hillf Danton wrote:
> > > > - load = task_h_load(env->p);
> > > > - dst_load = env->dst_stats.load + load;
> > > > - src_load = env->src_stats.load - load;
> > > > -
> > > > /*
> > > > - * If the improvement from just moving env->p direction is better
> > > > - * than swapping tasks around, check if a move is possible.
> > > > + * If dst node has spare capacity, then check if there is an
> > > > + * imbalance that would be overruled by the load balancer.
> > > > */
> > > > - maymove = !load_too_imbalanced(src_load, dst_load, env);
> > > > + if (env->dst_stats.node_type == node_has_spare) {
> > > > + unsigned int imbalance;
> > > > + int src_running, dst_running;
> > > > +
> > > > + /* Would movement cause an imbalance? */
> > > > + src_running = env->src_stats.nr_running - 1;
> > > > + dst_running = env->src_stats.nr_running + 1;
> > > > + imbalance = max(0, dst_running - src_running);
> > >
> > > Have trouble working out why 2 is magician again to make your test data nicer :P
> > >
> >
> > This is calculating what the nr_running would be after the move and
> > checking if an imbalance exists after the move forcing the load balancer
> > to intervene.
>
> Isn't that always going to work out to 2?
>

Crap, stupid cut and paste moving between source trees. Yes, this is
broken.

--
Mel Gorman
SUSE Labs

\
 
 \ /
  Last update: 2020-02-13 16:15    [W:0.055 / U:26.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site