lkml.org 
[lkml]   [2020]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] scsi: advansys: Replace zero-length array with flexible-array member
From
Date


On 2/12/20 19:14, Matthew Wilcox wrote:
> On Wed, Feb 12, 2020 at 06:02:11PM -0600, Gustavo A. R. Silva wrote:
>> Also, notice that, dynamic memory allocations won't be affected by
>> this change:
>
> Shouldn't you also convert this:
> asc_sg_head = kzalloc(sizeof(asc_scsi_q->sg_head) +
> use_sg * sizeof(struct asc_sg_list), GFP_ATOMIC);
> to use struct_size()?
>

It's not a requirement to do that prior to applying the change proposed by
this patch.

Thanks
--
Gustavo

\
 
 \ /
  Last update: 2020-02-13 07:02    [W:0.056 / U:8.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site