lkml.org 
[lkml]   [2020]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/8] dt-bindings: remoteproc: Add Qualcomm PIL info binding
On Thu 13 Feb 18:24 PST 2020, Stephen Boyd wrote:

> Quoting Bjorn Andersson (2020-02-10 16:50:52)
> > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,pil-info.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,pil-info.yaml
> > new file mode 100644
> > index 000000000000..8386a4da6030
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,pil-info.yaml
> > @@ -0,0 +1,42 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/remoteproc/qcom,pil-info.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Qualcomm peripheral image loader relocation info binding
> > +
> > +maintainers:
> > + - Bjorn Andersson <bjorn.andersson@linaro.org>
> > +
> > +description:
> > + This document defines the binding for describing the Qualcomm peripheral
>
> Maybe drop "This document defines the binding for describing".
>

Sounds reasonable.

> > + image loader relocation memory region, in IMEM, which is used for post mortem
> > + debugging of remoteprocs.
> > +
> > +properties:
> > + compatible:
> > + const: qcom,pil-reloc-info
> > +
> > + reg:
> > + maxItems: 1
> > +
> > +required:
> > + - compatible
> > + - reg
> > +
> > +examples:
> > + - |
> > + imem@146bf000 {
> > + compatible = "syscon", "simple-mfd";
> > + reg = <0 0x146bf000 0 0x1000>;
> > +
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > +
> > + pil-reloc {
>
> Should that be pil-reloc@94c?
>

Yes it should.

Thanks,
Bjorn

> > + compatible ="qcom,pil-reloc-info";
> > + reg = <0x94c 200>;
> > + };
> > + };

\
 
 \ /
  Last update: 2020-02-14 05:59    [W:0.074 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site