lkml.org 
[lkml]   [2020]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ARM: dts: imx: imx6qdl-gw553x.dtsi: add lsm9ds1 iio imu/magn support
On Tue, Jan 28, 2020 at 02:13:26PM -0800, Robert Jones wrote:
> Add one node for the accel/gyro i2c device and another for the separate
> magnetometer device in the lsm9ds1.
>
> Signed-off-by: Robert Jones <rjones@gateworks.com>
> ---
> arch/arm/boot/dts/imx6qdl-gw553x.dtsi | 31 +++++++++++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-gw553x.dtsi b/arch/arm/boot/dts/imx6qdl-gw553x.dtsi
> index a106689..305b2f0 100644
> --- a/arch/arm/boot/dts/imx6qdl-gw553x.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-gw553x.dtsi
> @@ -173,6 +173,25 @@
> pinctrl-0 = <&pinctrl_i2c2>;
> status = "okay";
>
> + lsm9ds1_m@1c {

Please use a generic node name?

> + compatible = "st,lsm9ds1-magn";
> + reg = <0x1c>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_mag>;
> + interrupt-parent = <&gpio1>;
> + interrupts = <2 IRQ_TYPE_EDGE_RISING>;
> + };
> +
> + lsm9ds1_ag@6a {

Ditto

> + compatible = "st,lsm9ds1-imu";
> + reg = <0x6a>;
> + st,drdy-int-pin = <1>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_acc_gyro>;
> + interrupt-parent = <&gpio7>;
> + interrupts = <13 IRQ_TYPE_LEVEL_HIGH>;
> + };
> +
> ltc3676: pmic@3c {
> compatible = "lltc,ltc3676";
> reg = <0x3c>;
> @@ -462,6 +481,18 @@
> >;
> };
>
> + pinctrl_mag: maggrp {
> + fsl,pins = <
> + MX6QDL_PAD_GPIO_2__GPIO1_IO02 0x1b0b0
> + >;
> + };
> +
> + pinctrl_acc_gyro: acc_gyrogrp {

Sort pinctrl nodes alphabetically. Also we generally do not use
underscore in node name.

Shawn

> + fsl,pins = <
> + MX6QDL_PAD_GPIO_18__GPIO7_IO13 0x1b0b0
> + >;
> + };
> +
> pinctrl_pps: ppsgrp {
> fsl,pins = <
> MX6QDL_PAD_ENET_RXD1__GPIO1_IO26 0x1b0b1
> --
> 2.9.2
>

\
 
 \ /
  Last update: 2020-02-14 04:05    [W:0.040 / U:4.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site