lkml.org 
[lkml]   [2020]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/6] docs: merge debugging-modules.txt into sysctl/kernel.rst
On Thu, 13 Feb 2020 18:46:57 +0100
Stephen Kitt <steve@sk2.org> wrote:

> This fits nicely in sysctl/kernel.rst, merge it (and rephrase it)
> instead of linking to it.
>
> Signed-off-by: Stephen Kitt <steve@sk2.org>
> ---
> Documentation/admin-guide/sysctl/kernel.rst | 16 ++++++++++++++-
> Documentation/debugging-modules.txt | 22 ---------------------
> 2 files changed, 15 insertions(+), 23 deletions(-)
> delete mode 100644 Documentation/debugging-modules.txt

One quick comment here:

> diff --git a/Documentation/admin-guide/sysctl/kernel.rst b/Documentation/admin-guide/sysctl/kernel.rst
> index 1de8f0b199b1..1aacd7a24f5a 100644
> --- a/Documentation/admin-guide/sysctl/kernel.rst
> +++ b/Documentation/admin-guide/sysctl/kernel.rst
> @@ -388,7 +388,21 @@ This flag controls the L2 cache of G3 processor boards. If
> modprobe
> ========
>
> -See Documentation/debugging-modules.txt.
> +This gives the full path of the modprobe command which the kernel will
> +use to load modules. This can be used to debug module loading
> +requests:
> +
> +::

This can be more readably written as just:

requests::

No need for the separate "::" line.

Thanks,

jon

\
 
 \ /
  Last update: 2020-02-13 19:56    [W:0.048 / U:7.576 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site