lkml.org 
[lkml]   [2020]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC 4/4] sched/fair: Take into runnable_avg to classify group
From
Date
On 2/13/20 6:32 PM, Valentin Schneider wrote:
>> @@ -7911,6 +7912,10 @@ group_has_capacity(unsigned int imbalance_pct, struct sg_lb_stats *sgs)
>> if (sgs->sum_nr_running < sgs->group_weight)
>> return true;
>>
>> + if ((sgs->group_capacity * imbalance_pct) <
>> + (sgs->group_runnable * 100))
>> + return false;
>> +
>
> I haven't stared long enough at patch 2, but I'll ask anyway - with this new
> condition, do we still need the next one (based on util)? AIUI
> group_runnable is >= group_util, so if group_runnable is within the allowed
> margin then group_util has to be as well.
>

Hmph, actually util_est breaks the runnable >= util assumption I think...

>> if ((sgs->group_capacity * 100) >
>> (sgs->group_util * imbalance_pct))
>> return true;

\
 
 \ /
  Last update: 2020-02-13 19:38    [W:0.054 / U:14.912 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site