lkml.org 
[lkml]   [2020]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 7/8] pid: export pidfd_get_pid
Hi Alexander,

On Wed, Feb 12, 2020 at 04:25:31PM -0800, Alexander Duyck wrote:
> On Wed, 2020-02-12 at 15:39 -0800, Minchan Kim wrote:
> > process_madvise syscall needs pidfd_get_pid function to translate
> > pidfd to pid so this patch exports the function.
> >
> > Cc: Christian Brauner <christian@brauner.io>
> > Signed-off-by: Minchan Kim <minchan@kernel.org>
>
> I think you might have misunderstood my earlier comments. This should be
> patch 2 in your set. What is patch 8 should be folded into you existing
> patch 2 and become patch 3 with the rest of your patches shifted by 1
> since you are reordering them.
>
> Otherwise the code itself appears to not have changed anything so it looks
> fine to me.
>
> Reviewed-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>

It was my intention because I expect supporting both pid and pidfd would be
controversial. It would make easy to revert.

Thanks for the review!

\
 
 \ /
  Last update: 2020-02-13 18:08    [W:0.045 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site