lkml.org 
[lkml]   [2020]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: install is no longer PHONY?
Hi Michael,

On Mon, Feb 10, 2020 at 2:15 PM Michael Ellerman <mpe@ellerman.id.au> wrote:
>
> Hi Masahiro,
>
> I noticed that "install" seems to be no longer PHONY, or at least if I
> have a file/directory called install then the build doesn't run.
>
> eg:
> $ touch install
> $ make install
> make: 'install' is up to date.
> $ rm install
> $ make install
> LDS arch/powerpc/boot/zImage.lds
> WRAP arch/powerpc/boot/zImage.pseries
> WRAP arch/powerpc/boot/zImage.epapr


I think the reason is
'install' is not specified as a phony target.


You can add 'PHONY += install' to fix it.



PHONY += install # please add this!
install:
$(Q)$(MAKE) $(build)=$(boot) install


Please do so in both arch/powerpc/Makefile and
arch/powerpc/boot/Makefile.




> In the past the presence of an install file/directory didn't have any
> affect.
>
> It seems this changed in:
> d79424137a73 ("kbuild: do not update config when running install targets")
>
> Was that expected?
>
> cheers


I do not think commit is related.

Prior to this commit, I still see the same issue.


$ git checkout d7942413^
$ touch install
$ make -s ARCH=powerpc allnoconfig
$ make ARCH=powerpc install
make: 'install' is up to date.



--
Best Regards
Masahiro Yamada

\
 
 \ /
  Last update: 2020-02-13 17:34    [W:0.054 / U:6.840 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site