Messages in this thread | | | Date | Wed, 12 Feb 2020 09:54:45 -0800 | From | Christoph Hellwig <> | Subject | Re: [PATCH v2 10/25] fs: Introduce i_blocks_per_page |
| |
On Wed, Feb 12, 2020 at 07:05:40AM -0800, Matthew Wilcox wrote: > > > + * Return: The number of filesystem blocks covered by this page. > > > + */ > > > +static inline > > > +unsigned int i_blocks_per_page(struct inode *inode, struct page *page) > > > > static inline unisnged int > > i_blocks_per_page(struct inode *inode, struct page *page) > > That's XFS coding style. Linus has specifically forbidden that: > > https://lore.kernel.org/lkml/1054519757.161606@palladium.transmeta.com/
Not just xfs but lots of places. But if you don't like that follow the real Linus style we use elsewhere:
static inline unsigned int i_blocks_per_page(struct inode *inode, struct page *page)
| |