Messages in this thread | | | From | linmiaohe <> | Subject | Re: [PATCH] KVM: x86: fix WARN_ON check of an unsigned less than zero | Date | Wed, 12 Feb 2020 12:47:37 +0000 |
| |
Paolo Bonzini <pbonzini@redhat.com> writes: > The check cpu->hv_clock.system_time < 0 is redundant since system_time is a u64 and hence can never be less than zero. But what was actually meant is to check that the result is positive, since kernel_ns and > v->kvm->arch.kvmclock_offset are both s64. > >Reported-by: Colin King <colin.king@canonical.com> >Suggested-by: Sean Christopherson <sean.j.christopherson@intel.com> >Addresses-Coverity: ("Macro compares unsigned to 0") >Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> >---
Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
| |