Messages in this thread | | | Date | Wed, 12 Feb 2020 13:39:02 +0100 | From | Joerg Roedel <> | Subject | Re: [PATCH 30/62] x86/head/64: Move early exception dispatch to C code |
| |
On Tue, Feb 11, 2020 at 02:44:45PM -0800, Andy Lutomirski wrote: > How about int (or bool) handled; Or just if (!early_make_pgtable) > return; This would also be nicer if you inverted the return value so > that true means "I handled it".
Okay, makes sense. Changed the return value of early_make_pgtable() to bool and this function to:
void __init early_exception(struct pt_regs *regs, int trapnr) { if (trapnr == X86_TRAP_PF && early_make_pgtable(native_read_cr2())) return;
early_fixup_exception(regs, trapnr); }
Regards,
Joerg
| |