Messages in this thread | | | From | Li Yang <> | Date | Wed, 12 Feb 2020 13:59:46 -0600 | Subject | Re: [PATCH] iommu/arm-smmu: fix the module name to be consistent with older kernel |
| |
On Wed, Feb 12, 2020 at 4:50 AM Will Deacon <will@kernel.org> wrote: > > On Tue, Feb 11, 2020 at 06:37:20PM -0600, Li Yang wrote: > > Commit cd221bd24ff5 ("iommu/arm-smmu: Allow building as a module") > > introduced a side effect that changed the module name from arm-smmu to > > arm-smmu-mod. This breaks the users of kernel parameters for the driver > > (e.g. arm-smmu.disable_bypass). This patch changes the module name back > > to be consistent. > > > > Signed-off-by: Li Yang <leoyang.li@nxp.com> > > --- > > drivers/iommu/Makefile | 4 ++-- > > drivers/iommu/{arm-smmu.c => arm-smmu-common.c} | 0 > > 2 files changed, 2 insertions(+), 2 deletions(-) > > rename drivers/iommu/{arm-smmu.c => arm-smmu-common.c} (100%) > > Can't we just override MODULE_PARAM_PREFIX instead of renaming the file?
I can do that. But on the other hand, the "mod" in the module name arm-smmu-mod.ko seems to be redundant and looks a little bit weird. Wouldn't it be cleaner to make it just arm-smmu.ko?
Regards, Leo
| |